Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flags/provider] handle alphabetically and in one place #3242

Merged
merged 3 commits into from
Jan 2, 2023
Merged

[flags/provider] handle alphabetically and in one place #3242

merged 3 commits into from
Jan 2, 2023

Conversation

jonasbadstuebner
Copy link
Contributor

Description
As in #3171 civo was forgotten to add to the flags description and was only added to the enum, I added civo to the list.
Also, to prevent this from happening in the future, I sorted the providers alphabetically.

And just to prove, that this is necessary, since I did an oopsie, there is a second commit, which readds providers that went missing when ordering.

Due to that and since there are a lot of providers, I put them into a seperate list, so we only have to maintain a single source of truth about the providers. The overview is bad otherwise.

Please DOUBLE CHECK, that all of them are in the list now!

Checklist

  • Unit tests updated
  • End user documentation updated

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 14, 2022
@jonasbadstuebner
Copy link
Contributor Author

/assign @seanmalloy

@szuecs
Copy link
Contributor

szuecs commented Jan 2, 2023

I validated that the list is correct via 3 files and loop with grep -q.

% for i in $(cat enum); do grep -q $i new 2>/dev/null || echo "$i not found"
done
[sszuecs@sandor-lab:/tmp/foo]% for i in $(cat enum); do grep -q $i providers 2>/dev/null || echo "$i not found"
done
zsh: exit 1     grep --exclude-dir=.svn --color -q $i providers 2> /dev/null
alibabacloud not found
zsh: exit 1     grep --exclude-dir=.svn --color -q $i providers 2> /dev/null
civo not found
zsh: exit 1     grep --exclude-dir=.svn --color -q $i providers 2> /dev/null
pihole not found
zsh: exit 1     grep --exclude-dir=.svn --color -q $i providers 2> /dev/null
plural not found

@szuecs
Copy link
Contributor

szuecs commented Jan 2, 2023

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 2, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DrBu7cher, szuecs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 2, 2023
@k8s-ci-robot k8s-ci-robot merged commit db79438 into kubernetes-sigs:master Jan 2, 2023
@jonasbadstuebner jonasbadstuebner deleted the add_civo_to_flag_description branch January 2, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njuettner njuettner Awaiting requested review from njuettner

@seanmalloy seanmalloy Awaiting requested review from seanmalloy

Assignees

@szuecs szuecs

@seanmalloy seanmalloy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jonasbadstuebner @szuecs @k8s-ci-robot @seanmalloy